[OAK-1655] DataStoreBlobStore does not take into maxLastModifiedTime when fetching all chunks

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.20
• Component/s: core
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 01/Apr/14 09:49
• Updated: 08/Apr/14 12:47
• Resolved: 01/Apr/14 10:16

Description

Currently the DataStoreBlobStore has a pending TODO

 @Override
    public Iterator<String> getAllChunkIds(long maxLastModifiedTime) throws Exception {
        //TODO Ignores the maxLastModifiedTime currently.
        return Iterators.transform(delegate.getAllIdentifiers(), new Function<DataIdentifier, String>() {
            @Nullable
            @Override
            public String apply(@Nullable DataIdentifier input) {
                return input.toString();
            }
        });
    }

Due to this it currently returns all blobId. This would issue when new binary gets created while a blob gc is running as such binaries might be considered orphan and deleted