Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-1558

Expose FileStoreBackupRestoreMBean for supported NodeStores

Details

    Description

      NodeStore implementations should expose the FileStoreBackupRestoreMBean in order to be interoperable with RepositoryManagementMBean. See OAK-1160.

      Attachments

        1. OAK-1558-01.patch
          3 kB
          Andrei Dulceanu

        Issue Links

          Activity

            mduerig, what is the difference between this issue and OAK-4866? To me, they seem to share the same goal.

            adulceanu Andrei Dulceanu added a comment - mduerig , what is the difference between this issue and OAK-4866 ? To me, they seem to share the same goal.
            mduerig Michael Dürig added a comment -

            This issue is about exposing and implementing management interfaces as MBeans. Specifically it is about exposing the FileStoreBackupRestoreMBean via the higher level RepositoryManagementMBean API. The latter is merely a wrapper around a couple of lower level management interfaces. See e.g. RepositoryManagementMBean.startRevisionGC() and how it relays back to RevisionGCMBean.startRevisionGC() and its underlying implementations. We should do the same for the backup and restore related functionality.

            OAK-4866 is about making the interfaces in org.apache.jackrabbit.oak.backup into a proper API for oak-segment-tar, which we can expose and apply semantic versioning to it. In order to do that we need to make sure these interfaces do not leak any internal implementation details as they currently do.

            mduerig Michael Dürig added a comment - This issue is about exposing and implementing management interfaces as MBeans. Specifically it is about exposing the FileStoreBackupRestoreMBean via the higher level RepositoryManagementMBean API. The latter is merely a wrapper around a couple of lower level management interfaces. See e.g. RepositoryManagementMBean.startRevisionGC() and how it relays back to RevisionGCMBean.startRevisionGC() and its underlying implementations. We should do the same for the backup and restore related functionality. OAK-4866 is about making the interfaces in org.apache.jackrabbit.oak.backup into a proper API for oak-segment-tar , which we can expose and apply semantic versioning to it. In order to do that we need to make sure these interfaces do not leak any internal implementation details as they currently do.
            adulceanu Andrei Dulceanu added a comment - - edited

            mduerig, not sure I understand the first paragraph above. Currently, RepositoryManager, the implementor of RepositoryManagementMBean relies in all backup/restore related methods (#startBackup, #startRestore, #getBackupStatus, #getRestoreStatus) on FileStoreBackupRestoreMBean, just as it does with RepositoryManagementMBean.startRevisionGC(). Is there anything else to do here?

            adulceanu Andrei Dulceanu added a comment - - edited mduerig , not sure I understand the first paragraph above. Currently, RepositoryManager , the implementor of RepositoryManagementMBean relies in all backup/restore related methods ( #startBackup, #startRestore, #getBackupStatus, #getRestoreStatus ) on FileStoreBackupRestoreMBean , just as it does with RepositoryManagementMBean.startRevisionGC() . Is there anything else to do here?
            mduerig Michael Dürig added a comment -

            AFICS the only missing bit is FileStoreBackupRestoreImpl (the implementation of FileStoreBackupRestoreMBean in Segment Tar not being registered in the SegmentNodeStoreService.

            mduerig Michael Dürig added a comment - AFICS the only missing bit is FileStoreBackupRestoreImpl (the implementation of FileStoreBackupRestoreMBean in Segment Tar not being registered in the SegmentNodeStoreService .

            mduerig, could you take a look at the proposed patch?

            adulceanu Andrei Dulceanu added a comment - mduerig , could you take a look at the proposed patch?
            mduerig Michael Dürig added a comment -

            Thanks for the patch, applied at http://svn.apache.org/viewvc?rev=1767509&view=rev

            mduerig Michael Dürig added a comment - Thanks for the patch, applied at http://svn.apache.org/viewvc?rev=1767509&view=rev

            Bulk close for 1.5.13

            edivad Davide Giannella added a comment - Bulk close for 1.5.13

            People

              adulceanu Andrei Dulceanu
              mduerig Michael Dürig
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: