[OAK-1431] Handling of empty or invalid names

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.17
• Component/s: core
• Assignee: Jukka Zitting
• Reporter: Jukka Zitting
• Created: 18/Feb/14 12:00
• Updated: 27/Feb/14 09:28
• Resolved: 19/Feb/14 14:21

Description

The NodeState.getChildNode() says the following about the name argument:

The name is an opaque string and is not parsed or otherwise interpreted by this method.

This causes some confusion higher up the stack, for example the following code produces an unexpected result:

Root root = ...;
Tree a = root.getTree("/");
Tree b = root.getTree("/").getChild("");
assert a.exists() && !b.exists() && a.getPath().equals(b.getPath()); // !

To avoid such confusion, I'd outlaw such potentially troublesome cases like empty names or names containing a forward slash all the way down at the NodeState level. The getChildNode() method could say something like this:

Names that are empty or ones contain a forward slash are considered invalid and cause an IllegalArgumentException to be thrown.

Code higher up the stack should probably be adjusted to better handle such edge cases.

Issue Links

• relates to: OAK-1424 Oak API allows to create hidden tree and properties