[OAK-1172] AbstractTree.getChildrenCount() not very performant due to INTERNAL_NODE_NAMES

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11
• Assignee: Unassigned
• Reporter: Tobias Bocanegra
• Created: 13/Nov/13 07:03
• Updated: 21/Nov/13 10:30
• Resolved: 13/Nov/13 11:15

Description

the AbstractTree.getChildrenCount() does unnecessary checks for hidden names:

        long count = nodeBuilder.getChildNodeCount(max);
        for (String name : INTERNAL_NODE_NAMES) {
            if (nodeBuilder.hasChildNode(name)) {
                count--;
            }
        }

this is not optimal, especially because the nodebuilder creates child builders:

    public boolean hasChildNode(@Nonnull String name) {
        return getChildNode(name).exists();
    }

Suggest: to extend the NodeBuilder.getChildNodeCount() method to accept an additional flag if to include hidden nodes or not.

Issue Links

• relates to: OAK-1173 NPE if checking for a non-existing node in version storage