[OAK-1147] SecureNodeBuilder/SecureNodeState: Consider using 'TreePermission#canReadProperties'

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 05/Nov/13 16:15
• Updated: 21/Nov/13 10:30
• Resolved: 06/Nov/13 10:11

Description

the methods #getProperties and #getPropertyCount have a shortcut for those cases where all properties are accessible.

however, the current implemention requires SecurityContext#canReadAll to return true in order to enable the shortcut. without knowing the very details of the SecureNodeState/Builder i would have expected that #canReadAllProperties would be sufficient.

jukkaz, do you remember what was the reason for using #canReadAll here? i changed it for test purpose and didn't see any difference... but that may also imply that we don't have enough or specific tests for this.