[OAK-11239] Remove usage of Guava newArrayList(vargargs) in test classes

• Type: Technical task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.72.0
• Component/s: test
• Assignee: Julian Reschke
• Reporter: Julian Reschke
• Created: 31/Oct/24 08:30
• Updated: 14/Nov/24 07:44
• Resolved: 31/Oct/24 13:37

Description

I'm separating this from the overall removal, because:

• there are several approaches (List.of, Arrays.asList, new Arraylist()), and for test cases they are easy to pick
• many of the uses are indeed in test cases because certain hardwired kinds of lists are tested (for instace, for test setup)

Approach:

• replace all of them by List.of
• change to Arrays.asList when failure due to missing support of `null`
• change to new ArrayList when failure due to immutability

This keeps the changes in tests as readable as possible,

Issue Links

• blocks: OAK-11023 Remove usage of Guava newArrayList
• links to: GitHub Pull Request #1836