[OAK-11070] WriteAccessController: avoid race condition

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.68.0
• Fix Version/s: 1.70.0
• Component/s: segment-azure
• Assignee: Unassigned
• Reporter: Axel Hanikel
• Created: 29/Aug/24 13:49
• Updated: 01/Oct/24 04:24
• Resolved: 17/Sep/24 09:48

Description

From a comment by miroslav:

Race condition might be possible for two threads simultaneously accessing enableWriting and checkWritingAllowed methods:

T1 enters checkWritingAllowed and finds isWritingAllowed is false.

T2 enters enableWriting sets isWritingAllowed to true, acquires the lock and calls notifyAll().

T1 misses notify signal and blocks at the beginning of the synchronised block.

This is not critical since T2 will again call notifyAll after the next lease refresh call, but certainly, this could be improved.

Issue Links

• links to: GitHub Pull Request #1676