[OAK-11055] Warnings "falling back to classic diff" fill the log

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.70.0
• Component/s: documentmk
• Assignee: Thomas Mueller
• Reporter: Thomas Mueller
• Created: 22/Aug/24 12:31
• Updated: 01/Oct/24 04:24
• Resolved: 27/Aug/24 11:58

Description

I see the following warning a lot in the log file. As this is a known case, I think we should not log the exception stack trace always. Only the message. Otherwise, the log file might cause out-of-disk-space.

00:04:16.333 [main] WARN  o.a.j.o.p.document.DocumentNodeStore - diffJournalChildren failed with IllegalStateException, falling back to classic diff
java.lang.IllegalStateException: Root document does not have a lastRev entry for local clusterId 0
    at org.apache.jackrabbit.oak.plugins.document.JournalDiffLoader.readTrunkChanges(JournalDiffLoader.java:139)
    at org.apache.jackrabbit.oak.plugins.document.JournalDiffLoader.call(JournalDiffLoader.java:75)
    at org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.diffImpl(DocumentNodeStore.java:3341)
    at org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore$9.call(DocumentNodeStore.java:1991)
    at org.apache.jackrabbit.oak.plugins.document.MemoryDiffCache$1.call(MemoryDiffCache.java:85)
    at org.apache.jackrabbit.oak.plugins.document.MemoryDiffCache$1.call(MemoryDiffCache.java:79)
    at org.apache.jackrabbit.oak.cache.CacheLIRS$Segment.load(CacheLIRS.java:1019)
    at org.apache.jackrabbit.oak.cache.CacheLIRS$Segment.get(CacheLIRS.java:980)
    at org.apache.jackrabbit.oak.cache.CacheLIRS.get(CacheLIRS.java:291)
    at org.apache.jackrabbit.oak.plugins.document.persistentCache.NodeCache.get(NodeCache.java:243)
    at org.apache.jackrabbit.oak.plugins.document.persistentCache.NodeCache.get(NodeCache.java:57)
    at org.apache.jackrabbit.oak.plugins.document.MemoryDiffCache.getChanges(MemoryDiffCache.java:79)
    at org.apache.jackrabbit.oak.plugins.document.TieredDiffCache.getChanges(TieredDiffCache.java:74)
    at org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.compare(DocumentNodeStore.java:1986)
    at org.apache.jackrabbit.oak.plugins.document.AbstractDocumentNodeState.compareAgainstBaseState(AbstractDocumentNodeState.java:118)
    at org.apache.jackrabbit.oak.spi.commit.EditorDiff.childNodeChanged(EditorDiff.java:147)
    at org.apache.jackrabbit.oak.plugins.document.JsopNodeStateDiffer.compareExisting(JsopNodeStateDiffer.java:100)
    at org.apache.jackrabbit.oak.plugins.document.JsopNodeStateDiffer$1.childNodeChanged(JsopNodeStateDiffer.java:65)
    at org.apache.jackrabbit.oak.plugins.document.DiffCache.parseJsopDiff(DiffCache.java:123)
    at org.apache.jackrabbit.oak.plugins.document.JsopNodeStateDiffer.compare(JsopNodeStateDiffer.java:51)
    at org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.compare(DocumentNodeStore.java:1993)
    at org.apache.jackrabbit.oak.plugins.document.AbstractDocumentNodeState.compareAgainstBaseState(AbstractDocumentNodeState.java:118)
    at org.apache.jackrabbit.oak.spi.commit.EditorDiff.childNodeChanged(EditorDiff.java:147)
    at org.apache.jackrabbit.oak.plugins.document.JsopNodeStateDiffer.compareExisting(JsopNodeStateDiffer.java:100)
    at org.apache.jackrabbit.oak.plugins.document.JsopNodeStateDiffer$1.childNodeChanged(JsopNodeStateDiffer.java:65)
    at org.apache.jackrabbit.oak.plugins.document.DiffCache.parseJsopDiff(DiffCache.java:123)
    at org.apache.jackrabbit.oak.plugins.document.JsopNodeStateDiffer.compare(JsopNodeStateDiffer.java:51)
    at org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.compare(DocumentNodeStore.java:1993)
    at org.apache.jackrabbit.oak.plugins.document.AbstractDocumentNodeState.compareAgainstBaseState(AbstractDocumentNodeState.java:118)
    at org.apache.jackrabbit.oak.spi.commit.EditorDiff.process(EditorDiff.java:51)
    at org.apache.jackrabbit.oak.index.indexer.document.incrementalstore.IncrementalFlatFileStoreStrategy.createSortedStoreFile(IncrementalFlatFileStoreStrategy.java:88)
    at org.apache.jackrabbit.oak.index.indexer.document.incrementalstore.IncrementalStoreBuilder.build(IncrementalStoreBuilder.java:124)
    at org.apache.jackrabbit.oak.index.indexer.document.DocumentStoreIndexerBase.buildStore(DocumentStoreIndexerBase.java:232)
    at com.adobe.granite.indexing.tool.BuildIndexStoreCmd.run(BuildIndexStoreCmd.java:167)
    at com.adobe.granite.indexing.tool.Main.main(Main.java:124) 

Issue Links

• links to: GitHub Pull Request #1665