Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-1091

TokenLoginModule#commit should throw an exception if TokenInfo is not created

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.11
    • core
    • None

    Description

      TokenLoginModule#commit should throw an exception if TokenInfo is not created

      if (ti != null) {
                          TokenCredentials tc = new TokenCredentials(ti.getToken());
                          Map<String, String> attributes = ti.getPrivateAttributes();
                          for (String name : attributes.keySet()) {
                              tc.setAttribute(name, attributes.get(name));
                          }
                          attributes = ti.getPublicAttributes();
                          for (String name : attributes.keySet()) {
                              tc.setAttribute(name, attributes.get(name));
                          }
                          subject.getPublicCredentials().add(tc);
                      }
      

      the code above should contain an else statement throwing a LoginException

      Attachments

        Activity

          People

            angela Angela Schreiber
            asanso Antonio Sanso
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: