[OAK-10771] Add disk cache size stats and issue warning if evicted segment has zero length

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.62.0
• Fix Version/s: 1.64.0
• Component/s: segment-azure
• Assignee: Unassigned
• Reporter: Axel Hanikel
• Created: 19/Apr/24 09:25
• Updated: 27/May/24 19:51
• Resolved: 22/May/24 14:57

Description

Note: The component is actually segment-remote but that's not on the list.

The persistent disk cache computes its size internally by adding/subtracting the size of added/purged segments. We would like to be able to see if that computation is correct, by having both the computed size and the effective size on disk in the metrics.

The background for this is that in a few rare instances, the disk cache evicted too many items (down to almost zero) instead of the expected 65% of its max size.

Also we want to make sure that no evictions happen on items that have a length of zero. We're not sure if that happens or not, so the change is to refuse eviction in that case and log a warning instead.

Issue Links

• links to: GitHub Pull Request #1427