[OAK-10655] Improve warning emitted for Unexpected changes performed on a non-default mount

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.62.0
• Component/s: composite
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 15/Feb/24 16:26
• Updated: 09/Apr/24 04:25
• Resolved: 01/Mar/24 15:20

Description

Currently the feature provided in OAK-9208 emits WARNs like the following

5.02.2024 11:46:49.748 *WARN* [ResourceResolverFactory registration] org.apache.jackrabbit.oak.composite.impl.NonDefaultMountWriteReportingObserver$ChangeReporter Unexpected changes (38) performed on a non-default mount. Printing at most 50_- /apps : Changed_- ....
java.lang.RuntimeException: null
	at org.apache.jackrabbit.oak.composite.impl.NonDefaultMountWriteReportingObserver$CountingDiff.report(NonDefaultMountWriteReportingObserver.java:106)
	at org.apache.jackrabbit.oak.composite.impl.NonDefaultMountWriteReportingObserver.contentChanged(NonDefaultMountWriteReportingObserver.java:88)
	at org.apache.jackrabbit.oak.spi.commit.CompositeObserver.contentChanged(CompositeObserver.java:51)
	at org.apache.jackrabbit.oak.spi.commit.ChangeDispatcher.contentChanged(ChangeDispatcher.java:79)
	at org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler$ObservableLockBasedScheduler.contentChanged(LockBasedScheduler.java:394)
	at org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler.execute(LockBasedScheduler.java:303)
	at org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler.schedule(LockBasedScheduler.java:270)
	at org.apache.jackrabbit.oak.segment.SegmentNodeStore.merge(SegmentNodeStore.java:211)
	at org.apache.jackrabbit.oak.core.MutableRoot.commit(MutableRoot.java:262)
	at org.apache.jackrabbit.oak.jcr.delegate.WorkspaceDelegate$WorkspaceCopy.perform(WorkspaceDelegate.java:130)
	at org.apache.jackrabbit.oak.jcr.delegate.WorkspaceDelegate.copy(WorkspaceDelegate.java:99)
	at org.apache.jackrabbit.oak.jcr.session.WorkspaceImpl$2.performVoid(WorkspaceImpl.java:163)
	at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.performVoid(SessionDelegate.java:299)
	at org.apache.jackrabbit.oak.jcr.session.WorkspaceImpl.copy(WorkspaceImpl.java:150)
	at org.apache.jackrabbit.oak.jcr.session.WorkspaceImpl.copy(WorkspaceImpl.java:132)
	at 
.....

It would be useful to add a dedicated exception message to the throwable (or prevent logging it) and indicate that this only indicates where the JCR session has been committed.

Issue Links

• is caused by: OAK-9208 Log unexpected writes to the paths designated as part of a non-default mount
• links to: GitHub Pull Request #1311