Major Description
There could be a case where a node was moved/renamed which apparently results the incremental FFS to have 2 entries.
For example,
NodeA | {"prop":"value"}
renamed to NodeB | {"prop":"value"}
then the incremental FFS has entries -
NodeA | {"prop":"value"} | D
NodeB | {"prop":"value"} | M
The second entry's operand should be A and not M.
The above analysis is an assumption from some observations during some tests on a large repository.
A more detailed test case needs to be written to investigate this further.
But the impact of this is that merge for this inc store fails here https://jira.corp.adobe.com/browse/GRANITE-48075#:~:text=https%3A//github.com/apache/jackrabbit%2Doak/blob/trunk/oak%2Drun%2Dcommons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/MergeIncrementalFlatFileStore.java%23L118 .
A simple solution could be to treat modification same as addition.
Attachments
Issue Links
- links to