[OAK-10311] Optimize SegmentBlob#equals for segment blobs that originate from the same blob store

• Type: Story
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.52.0
• Fix Version/s: 1.60.0
• Component/s: segment-tar
• Assignee: Andrei Dulceanu
• Reporter: Axel Hanikel
• Created: 19/Jun/23 09:15
• Updated: 06/Dec/23 18:50
• Resolved: 15/Nov/23 16:25

Description

SegmentBlob#equals can be optimized for blobs originating from the same external blob store: In that case, SegmentBlob#getBlobId() can be used to determine if the blobs are equal or not. That change should avoid falling back to a byte-by-byte comparison if the two blobs have the same size, which can be very expensive for larger blobs.

The optimization should be placed behind a code/feature toggle or system property and disabled by default. The reason is that the contract of Blob#getContentIdentity does not mention the special case where Blobs reside in the same blob store.

As part of this story, integration and benchmark tests should be created to demonstrate gains in performance and correct behavior.

Issue Links

• split to: OAK-10345 Add debug logger for bytewise comparison of big blobs
• links to: GitHub Pull Request #1150