Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: nutchgora
    • Component/s: None
    • Labels:
      None

      Description

      We are already inheriting a dependency on slf4j from Solr so we might as well use it
      Any thoughts on this?

      1. NUTCH-851-v2.patch
        121 kB
        Julien Nioche

        Activity

        Hide
        Andrzej Bialecki added a comment -

        Definitely, +1.

        Show
        Andrzej Bialecki added a comment - Definitely, +1.
        Hide
        Chris A. Mattmann added a comment -

        Boo!

        ...fan of JDK logging...

        Show
        Chris A. Mattmann added a comment - Boo! ...fan of JDK logging...
        Hide
        Andrzej Bialecki added a comment -

        You are being facetious, aren't you. JDK logging is arguably the worst logging API (if you dismiss System.out.println), giving you the least control and flexibility. Slf4j is the opposite, and allows you even to use JDK logging, if that's what you like...

        And we have to include slf4j anyway.

        Show
        Andrzej Bialecki added a comment - You are being facetious, aren't you. JDK logging is arguably the worst logging API (if you dismiss System.out.println), giving you the least control and flexibility. Slf4j is the opposite, and allows you even to use JDK logging, if that's what you like... And we have to include slf4j anyway.
        Hide
        Chris A. Mattmann added a comment -

        LOL yep I'm sort of a fan of JDK logging b/c it doesn't introduce extra dependencies. To be honest, most of the logging frameworks all look the same to me, but it's probably b/c I haven't compared them in detail.

        The facetious part though is that I don't really feel strongly about it to do anything but boo to adding extra dependencies

        Show
        Chris A. Mattmann added a comment - LOL yep I'm sort of a fan of JDK logging b/c it doesn't introduce extra dependencies. To be honest, most of the logging frameworks all look the same to me, but it's probably b/c I haven't compared them in detail. The facetious part though is that I don't really feel strongly about it to do anything but boo to adding extra dependencies
        Hide
        Pham Tuan Minh added a comment -

        I'm a fan of Log4j, but I love something is simple, compact and no more dependencies like JDK logging.

        By this, it allows end user to choose their desired logging framework at deployment time. It's very interesting feature!

        Show
        Pham Tuan Minh added a comment - I'm a fan of Log4j, but I love something is simple, compact and no more dependencies like JDK logging. By this, it allows end user to choose their desired logging framework at deployment time. It's very interesting feature!
        Hide
        Julien Nioche added a comment -

        Used the migrator tool from slf4j http://www.slf4j.org/migrator.html + manually replaced fatal() by error() + various minor fixes

        I have commented out the dependency on commons-logging but left the log4j adapter (slf4j-log4j12) so that we are now using log4j through slf4j. The beauty of it is that users can swap to their favourite logging system by replacing the ivy dependencies

        The patch compiles and goes through the tests OK

        Show
        Julien Nioche added a comment - Used the migrator tool from slf4j http://www.slf4j.org/migrator.html + manually replaced fatal() by error() + various minor fixes I have commented out the dependency on commons-logging but left the log4j adapter (slf4j-log4j12) so that we are now using log4j through slf4j. The beauty of it is that users can swap to their favourite logging system by replacing the ivy dependencies The patch compiles and goes through the tests OK
        Hide
        Julien Nioche added a comment -

        Updated the patch to the 2.0 code.

        Will commit tomorrow if there aren't any objections

        Show
        Julien Nioche added a comment - Updated the patch to the 2.0 code. Will commit tomorrow if there aren't any objections
        Hide
        Julien Nioche added a comment -

        Committed revision 983885

        Show
        Julien Nioche added a comment - Committed revision 983885

          People

          • Assignee:
            Julien Nioche
            Reporter:
            Julien Nioche
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development