[NUTCH-3027] Trivial resource leak patch in DomainSuffixes.java

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.20
• Fix Version/s: 1.20
• Component/s: util
• Flags: Patch
• Assignee: Markus Jelsma
• Reporter: Sascha Kehrli
• Created: 18/Jan/24 22:24
• Updated: 13/Mar/24 14:51
• Resolved: 19/Jan/24 11:57

Description

Found a trivial resource leak in .../util/DomainSuffixes.java, where an InputStream is not closed:

InputStream input = this.getClass().getClassLoader().getResourceAsStream(file);
try {
    new DomainSuffixesReader().read(this, input);
} catch (Exception ex) {
    LOG.warn(StringUtils.stringifyException(ex));
} 

 

instead of:

try (InputStream input = this.getClass().getClassLoader().getResourceAsStream(file)) {
    new DomainSuffixesReader().read(this, input);
} catch (Exception ex) {
    LOG.warn(StringUtils.stringifyException(ex));
} 

Where the InputStream is automatically closed.

Issue Links

• links to: GitHub Pull Request #802