[NUTCH-2911] Add cleanup call in Fetcher.java

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.18
• Fix Version/s: 1.19
• Component/s: fetcher
• Labels: improvement
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Prakhar Chaube
• Created: 30/Nov/21 13:10
• Updated: 13/Mar/24 14:51
• Resolved: 03/Dec/21 08:18

Description

Fetcher's inner class, FetcherRun overrides Hadoop Mapper's run().
Even though Nutch's FetcherRun doesn't need an explicit call the Mapper's cleanup() (Which is a blank function), it would increase the readability and completeness of the run Method to do so.
Ideally, every implementation of Mapper is supposed to do the following tasks:
1. Perform Setup

2.  Call map on the data set

3. Perform cleanups.

Moreover, in case a custom Fetcher is written extending Fetcher.java cleanup could get easily missed out.

PR for Fix: here

Issue Links

• links to: GitHub Pull Request #708