[NUTCH-1883] bin/crawl: use function to run bin/nutch and check exit value

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9, 2.2.1
• Fix Version/s: 2.3, 1.10
• Patch Info: Patch Available
• Assignee: Sebastian Nagel
• Reporter: Sebastian Nagel
• Created: 25/Oct/14 11:12
• Updated: 13/Mar/24 14:50
• Resolved: 11/Nov/14 16:21

Description

In bin/crawl for every Nutch command the exit value is checked explicitly:

"$bin/nutch" ...
RETCODE=$?
if [ $RETCODE -ne 0 ] 
then exit $RETCODE 
fi

This could be simplified by calling bin/nutch from one function which does the check. The function could also echo the command, show an error message, etc. The main advantage is short and clear code. In case a special treatment of exit values is required (cf. NUTCH-1829) we still could call bin/nutch directly.