i see that prevFetchTime is not fed into the schedule#setPageRetrySchedule, so i also not fed prevModifiedTime into it. How do your think about it?
I am not quite understanding you here, I did not mention prevFetchTime, we are solely talking about long prevModifiedTime here. Can you please expand upon your comment?
- My point is as follows: so far this patch (correctly) accounts for the CrawlStatus.STATUS_NOTMODIFIED case however it does not account for CrawlStatus.STATUS_RETRY and CrawlStatus.STATUS_GONE which both setPageRetrySchedule(String url, WebPage page, long prevFetchTime, long prevModifiedTime, long fetchTime) and setPageGoneSchdule(String url, WebPage page, long prevFetchTime, long prevModifiedTime, long fetchTime) respectively.
As you see above, the current input parameters for the long prevModifiedTime for both method calls is set to 0L... which IMHO is incorrect.
Do you have a comment on this?
With regards to point two, I agree with you. We should address this in a different issue if and when one wishes to do so. Thanks for the insight.