Uploaded image for project: 'Nutch'
  1. Nutch
  2. NUTCH-1362

Fix error handling of urls with empty fields

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: nutchgora
        • Fix Version/s: nutchgora
        • Component/s: None
        • Labels:
          None

          Description

          Within o.a.n.util.TableUtil.reverseAppendSplits() a simple if (split.length > 0) block enables us to address this issue.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ferdy.g Ferdy Galema added a comment -

            Hey Lewis,

            This patches fixes the problem and makes the reversing a bit faster by using StringUtils.split instead of String.split. (The latter compiles a regular expression every time a split is done. That's a bit excessive for simple dot and colon splitting.)

            Tested and verified.

            Show
            ferdy.g Ferdy Galema added a comment - Hey Lewis, This patches fixes the problem and makes the reversing a bit faster by using StringUtils.split instead of String.split. (The latter compiles a regular expression every time a split is done. That's a bit excessive for simple dot and colon splitting.) Tested and verified.
            Hide
            Permalink
            ferdy.g Ferdy Galema added a comment -

            Btw this is a duplicate of NUTCH-1077.

            Show
            ferdy.g Ferdy Galema added a comment - Btw this is a duplicate of NUTCH-1077 .
            Hide
            Permalink
            lewismc Lewis John McGibbney added a comment -

            +1 to commit Ferdy. I am happy with this and simplification.

            Show
            lewismc Lewis John McGibbney added a comment - +1 to commit Ferdy. I am happy with this and simplification.
            Hide
            Permalink
            ferdy.g Ferdy Galema added a comment -

            Done! Thanks.

            Show
            ferdy.g Ferdy Galema added a comment - Done! Thanks.
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in Nutch-nutchgora #250 (See https://builds.apache.org/job/Nutch-nutchgora/250/)
            NUTCH-1362 Fix error handling of urls with empty fields (Revision 1337091)

            Result = SUCCESS
            ferdy :
            Files :

            • /nutch/branches/nutchgora/CHANGES.txt
            • /nutch/branches/nutchgora/src/java/org/apache/nutch/util/TableUtil.java
            Show
            hudson Hudson added a comment - Integrated in Nutch-nutchgora #250 (See https://builds.apache.org/job/Nutch-nutchgora/250/ ) NUTCH-1362 Fix error handling of urls with empty fields (Revision 1337091) Result = SUCCESS ferdy : Files : /nutch/branches/nutchgora/CHANGES.txt /nutch/branches/nutchgora/src/java/org/apache/nutch/util/TableUtil.java

              People

              • Assignee:
                Unassigned
                Reporter:
                lewismc Lewis John McGibbney
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development