Nutch
  1. Nutch
  2. NUTCH-1172

AbstractNuchTest should have a generic testdir instead of specific 'inject' dir

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: nutchgora
    • Fix Version/s: nutchgora
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      This is a very trivial issue but nevertheless important for the goal to have clarified tests. This patch changes the testdir in AbstractNutchTest to "build/test/working" so that it is not specifically aimed towards the TestInjector test anymore. Also removes some unnecessary imports.

      I was actually unsure whether to move the testdir to TestInjector altogether, but then again perhaps it's nice to have a generic working dir available to any test that decides to use one.

      If there aren't any objections, I will be committing this patch in a few days.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        19d 7h 17m 1 Ferdy Galema 02/Nov/11 16:12
        Hide
        Hudson added a comment -

        Integrated in Nutch-nutchgora-ant #10 (See https://builds.apache.org/job/Nutch-nutchgora-ant/10/)
        NUTCH-1172 AbstractNuchTest should have a generic testdir instead of specific 'inject' dir

        ferdy : http://svn.apache.org/viewvc/nutch/branches/nutchgora/viewvc/?view=rev&root=&revision=1196663
        Files :

        • /nutch/branches/nutchgora/CHANGES.txt
        • /nutch/branches/nutchgora/src/test/org/apache/nutch/util/AbstractNutchTest.java
        Show
        Hudson added a comment - Integrated in Nutch-nutchgora-ant #10 (See https://builds.apache.org/job/Nutch-nutchgora-ant/10/ ) NUTCH-1172 AbstractNuchTest should have a generic testdir instead of specific 'inject' dir ferdy : http://svn.apache.org/viewvc/nutch/branches/nutchgora/viewvc/?view=rev&root=&revision=1196663 Files : /nutch/branches/nutchgora/CHANGES.txt /nutch/branches/nutchgora/src/test/org/apache/nutch/util/AbstractNutchTest.java
        Hide
        Hudson added a comment -

        Integrated in Nutch-nutchgora #56 (See https://builds.apache.org/job/Nutch-nutchgora/56/)
        NUTCH-1172 AbstractNuchTest should have a generic testdir instead of specific 'inject' dir

        ferdy : http://svn.apache.org/viewvc/nutch/branches/nutchgora/viewvc/?view=rev&root=&revision=1196663
        Files :

        • /nutch/branches/nutchgora/CHANGES.txt
        • /nutch/branches/nutchgora/src/test/org/apache/nutch/util/AbstractNutchTest.java
        Show
        Hudson added a comment - Integrated in Nutch-nutchgora #56 (See https://builds.apache.org/job/Nutch-nutchgora/56/ ) NUTCH-1172 AbstractNuchTest should have a generic testdir instead of specific 'inject' dir ferdy : http://svn.apache.org/viewvc/nutch/branches/nutchgora/viewvc/?view=rev&root=&revision=1196663 Files : /nutch/branches/nutchgora/CHANGES.txt /nutch/branches/nutchgora/src/test/org/apache/nutch/util/AbstractNutchTest.java
        Ferdy Galema made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s nutchgora [ 12314893 ]
        Resolution Fixed [ 1 ]
        Hide
        Ferdy Galema added a comment -

        Committed!

        Show
        Ferdy Galema added a comment - Committed!
        Hide
        Ferdy Galema added a comment -

        (Oops did not mean to edit that post, it should have gone in a new comment.)

        Show
        Ferdy Galema added a comment - (Oops did not mean to edit that post, it should have gone in a new comment.)
        Ferdy Galema made changes -
        Description This is a very trivial issue but nevertheless important for the goal to have clarified tests. This patch changes the testdir in AbstractNutchTest to "build/test/working" so that it is not specifically aimed towards the TestInjector test anymore. Also removes some unnecessary imports.

        I was actually unsure whether to move the testdir to TestInjector altogether, but then again perhaps it's nice to have a generic working dir available to any test that decides to use one.
        This is a very trivial issue but nevertheless important for the goal to have clarified tests. This patch changes the testdir in AbstractNutchTest to "build/test/working" so that it is not specifically aimed towards the TestInjector test anymore. Also removes some unnecessary imports.

        I was actually unsure whether to move the testdir to TestInjector altogether, but then again perhaps it's nice to have a generic working dir available to any test that decides to use one.

        If there aren't any objections, I will be committing this patch in a few days.
        Ferdy Galema made changes -
        Field Original Value New Value
        Attachment NUTCH-1172-v1.patch [ 12499002 ]
        Ferdy Galema created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Ferdy Galema
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development