[NUMBERS-65] "RootsOfUnity" vs "nthRoot"

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0-beta1
• Component/s: complex
• Labels: API delete gsoc2018
• Assignee: Unassigned
• Reporter: Gilles Sadowski
• Created: 02/Feb/18 14:37
• Updated: 08/Apr/20 12:00
• Resolved: 24/Apr/18 14:08

Description

There is partial overlap of functionality between class RootsOfUnity and method nthRoot (in class Complex).

The latter is more general (any complex number) but the former allows a negative argument (to specify clockwise ordering).

Also, the implementations are different; it should be checked which is more accurate (and then account for possible performance trade-offs).

API-wise, I think that we should keep nthRoot (and delete RootsOfUnity).