[NUMBERS-137] Suspicious special case in "log"

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0-beta1
• Component/s: complex
• Assignee: Alex Herbert
• Reporter: Gilles Sadowski
• Created: 03/Oct/19 14:53
• Updated: 08/Apr/20 12:00
• Resolved: 11/Dec/19 20:51

Description

In the implementation (copied below), two special cases return the same value.
If intended, the two conditions should be grouped.

    public Complex log() {
        if (real == Double.POSITIVE_INFINITY &&
            imaginary == Double.POSITIVE_INFINITY) {
            return new Complex(Double.POSITIVE_INFINITY, PI_OVER_4);
        } else if (real == Double.POSITIVE_INFINITY &&
                   Double.isNaN(imaginary)) {
            return new Complex(Double.POSITIVE_INFINITY, Double.NaN);
        } else if (Double.isNaN(real) &&
                   imaginary == Double.POSITIVE_INFINITY) {
            return new Complex(Double.POSITIVE_INFINITY, Double.NaN);
        }
        return new Complex(Math.log(abs()),
                           Math.atan2(imaginary, real));
    }

Issue Links

• relates to: NUMBERS-136 "log10" inconsistent with "log"