[NUMBERS-123] "BigFraction(double)" is unnecessary

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Done
• Fix Version/s: 1.0-beta1
• Component/s: fraction
• Assignee: Gilles Sadowski
• Reporter: Gilles Sadowski
• Created: 30/Jun/19 21:11
• Updated: 08/Apr/20 12:00
• Resolved: 09/Aug/19 11:03

Description

Constructor BigFraction(double value) is only called from the from(double value) method.
Actually, this constructor is misleading as it is indeed primarily a conversion from which appropriate numerator and denominator fields are computed; those could be set by
the "direct" constructor BigFraction(BigInteger num, BigInteger den).

Moreover, the private field ZERO goes through this conversion code whereas it could constructed "directly", e.g. using of(0). Similarly for field ONE.

Issue Links

• links to: GitHub Pull Request #60