Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 1.5.0-incubating
    • Component/s: Maven Plugins
    • Labels:
      None

      Description

      I think it is not necessary to resolve pdbs by default.

      It should at least be enough to resolve them for testing (although, if it slows down passing tests, it might be better not to have nice stacktraces - but that could be optional).

        Activity

        Hide
        Lars Corneliussen added a comment -

        Victor Stefoglo, Brett Porter Any idea on how we could do that? we could pass properties to require and from there to the custom resolvers. all mojos that call require would then have to provide parameters for controlling pdb resolving...

        ugly solution, uh? What do you guys think?

        Show
        Lars Corneliussen added a comment - Victor Stefoglo , Brett Porter Any idea on how we could do that? we could pass properties to require and from there to the custom resolvers. all mojos that call require would then have to provide parameters for controlling pdb resolving... ugly solution, uh? What do you guys think?
        Hide
        Lars Corneliussen added a comment -

        What about applying the artifactfilter before actually resolving them? When resolving we already pass a filter that can filter on type and/or scope, but do not apply that one on additional artifacts we intend to resolve.

        Show
        Lars Corneliussen added a comment - What about applying the artifactfilter before actually resolving them? When resolving we already pass a filter that can filter on type and/or scope, but do not apply that one on additional artifacts we intend to resolve.
        Hide
        Victor Stefoglo added a comment -

        What about if we add ContributorSettings component in plexus container which will store all contributor properties and
        use this component in contributor classes.
        Also add new goal to maven-resolver-plugin:sources(default phase initialize) which will get ContributorSettings from
        plexus container and set resolve pdb property to true. So when the project will need resolving pdb(sources), it should include
        maven-resolver-plugin:sources goal.
        What do you think about that?

        Show
        Victor Stefoglo added a comment - What about if we add ContributorSettings component in plexus container which will store all contributor properties and use this component in contributor classes. Also add new goal to maven-resolver-plugin:sources(default phase initialize) which will get ContributorSettings from plexus container and set resolve pdb property to true. So when the project will need resolving pdb(sources), it should include maven-resolver-plugin:sources goal. What do you think about that?
        Hide
        Lars Corneliussen added a comment -

        [19.06.13 18:18:14] Lars Corneliussen: not sure if i understood.
        [19.06.13 18:18:27] Lars Corneliussen: would we have one contributorsettings pr. contributor?
        [19.06.13 18:18:44] Lars Corneliussen: or would it just be a typed keyvalue-store?

        For the xtra sources-plugin, i'd rather like to do that explicitely for each mojo that does resolve things...

        Show
        Lars Corneliussen added a comment - [19.06.13 18:18:14] Lars Corneliussen: not sure if i understood. [19.06.13 18:18:27] Lars Corneliussen: would we have one contributorsettings pr. contributor? [19.06.13 18:18:44] Lars Corneliussen: or would it just be a typed keyvalue-store? For the xtra sources-plugin, i'd rather like to do that explicitely for each mojo that does resolve things...
        Hide
        Lars Corneliussen added a comment -

        compiler-plugin:init doesn't need to resolve pdb, IMHO

        Show
        Lars Corneliussen added a comment - compiler-plugin:init doesn't need to resolve pdb, IMHO
        Hide
        Lars Corneliussen added a comment -

        I implemented the filter-based approach. Also did some other enhancements.

        PDB is by default disabled for init and compile, but enabled for tests.

        The various application packaging mojos should also be provided with the option to disable/enable pdb resolving.
        Maybe it is a good point in time to also implement the vsdocs-resolver and handle those paralelly. We can also have a "ComplementaryArtifactFilter" which skips complementary resolved types...

        ping Victor Stefoglo

        Show
        Lars Corneliussen added a comment - I implemented the filter-based approach. Also did some other enhancements. PDB is by default disabled for init and compile, but enabled for tests. The various application packaging mojos should also be provided with the option to disable/enable pdb resolving. Maybe it is a good point in time to also implement the vsdocs-resolver and handle those paralelly. We can also have a "ComplementaryArtifactFilter" which skips complementary resolved types... ping Victor Stefoglo

          People

          • Assignee:
            Unassigned
            Reporter:
            Lars Corneliussen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development