Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 1.5.0-incubating
    • Component/s: Maven Plugins
    • Labels:
      None

      Activity

      Hide
      Lars Corneliussen added a comment -

      Brett Porter, Victor Stefoglo: I checked artifact.getRepository()... it is null; so i have no idea how we could find out where to resolve stuff from.

      How does maven do with sources? Would it try to get them from everywhere?

      Show
      Lars Corneliussen added a comment - Brett Porter , Victor Stefoglo : I checked artifact.getRepository()... it is null; so i have no idea how we could find out where to resolve stuff from. How does maven do with sources? Would it try to get them from everywhere?
      Hide
      Victor Stefoglo added a comment -

      Lars Corneliussen I looked in mojo sources of maven-dependency-plugin:sources, It use the same maven artifact resolver, and provide all remote repositories from the project, therefore It try to resolve source artifacts from all repositories.
      So, I have no idea how to resolve PDBs from the same repo the dll was resolved from.

      Notes: I see that maven source resolver also ignore ArtifactResolutionException (it's seem to be a connection error) when try to resolve source artifacts. How do you think, should you ignore it in PDB artifact contributor also?

      My question is: why we need to limit resolving PDBs artifacts to one repo? Why if I have to repositories external and internal, external contains all artifacts without sources(PDBs) and internal the same artifacts with sources, and we have a project which have reference to these repositories. So if artifact will be resolved from external repository we cannot be able to resolve PDB artifact in this case.

      Show
      Victor Stefoglo added a comment - Lars Corneliussen I looked in mojo sources of maven-dependency-plugin:sources, It use the same maven artifact resolver, and provide all remote repositories from the project, therefore It try to resolve source artifacts from all repositories. So, I have no idea how to resolve PDBs from the same repo the dll was resolved from. Notes: I see that maven source resolver also ignore ArtifactResolutionException (it's seem to be a connection error) when try to resolve source artifacts. How do you think, should you ignore it in PDB artifact contributor also? My question is: why we need to limit resolving PDBs artifacts to one repo? Why if I have to repositories external and internal, external contains all artifacts without sources(PDBs) and internal the same artifacts with sources, and we have a project which have reference to these repositories. So if artifact will be resolved from external repository we cannot be able to resolve PDB artifact in this case.
      Hide
      Brett Porter added a comment -

      I agree, I don't think there's significant value in trying to constrain the source repository.

      Show
      Brett Porter added a comment - I agree, I don't think there's significant value in trying to constrain the source repository.
      Hide
      Lars Corneliussen added a comment -

      Ok. you won

      Show
      Lars Corneliussen added a comment - Ok. you won

        People

        • Assignee:
          Unassigned
          Reporter:
          Lars Corneliussen
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development