[NPANDAY-422] [regression introduced by 186] .NET-Plugins can not have custom dependencies

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4-incubating
• Fix Version/s: 1.5.0-incubating
• Component/s: Maven Plugins
• Assignee: Lars Corneliussen
• Reporter: Lars Corneliussen
• Created: 01/May/11 22:08
• Updated: 09/May/12 07:10
• Resolved: 09/May/12 07:10

Description

For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.

But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.

NetExecutableFactoryImpl.java/getNetExecutableFromRepository

//TODO: Replace
String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
localRepository ).getAbsolutePath();

The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.

getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.

PathUtil.getDotNetArtifact(Artifact, String)

/**
* Returns the path of the artifact within the user assembly cache.
*
* @param artifact        the artifact to find the path of. This value should not be null.
* @return the path of the artifact within the user assembly cache or null if either of the specified
*         parameters is null
*/
public static File getDotNetArtifact( Artifact artifact, String source )

Issue Links

• relates to: NPANDAY-186 Remove the uac and pab directories