[NIFIREG-205] NiFi Registry DB gets out of sync with git repository, no apprent remediation

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.4.0
• Environment: Centos 7.5
• Assignee: Koji Kawamura
• Reporter: Dye357
• Created: 05/Oct/18 11:32
• Updated: 19/Feb/19 14:52
• Resolved: 06/Nov/18 19:47

Description

I've observed a couple issues with the GitFlowPersistenceAdapter:

1. When adding a new process group to NIFREG If for any reason the git repository is in a "dirty" (untracked file) state the adding of the process group fails. However an entry is still created in the DB with a version of 0. Once in this state you cannot delete the flow from NIFIREG and you cannot restart version control from nifi with the same name. I assume the only way to fix this is to manually go into the DB and delete the record.
2. When using Remote To Push, if the push fails the same behavior in #1 is exhibited. It's not reasonable to expect that a push will always succeed. The remote git repository could be offline for maintenance etc...

Steps to reproduce:

1. Start nifi registry with an empty db and clean git repo.
2. add an untracked file to the git repo but do-not commit it.
3. Start a processgroup under version control.
4. Expect Failure in Nifi UI
5. Expect Exception in Log saying untracked files in git repo.
6. Delete flow from nifi-registry using Actions -> Delete.
7. Expect Failure case, recieve error deleting flow message.
8. Refresh nifi-registry UI - flow is still present, version is 0.

Issue Links

• duplicates: NIFIREG-204 Registry in Inconsistent State
• is blocked by: NIFI-5792 NiFi should keep the created versioned flow information in case snapshot creation failure
• is duplicated by: NIFIREG-228 Cannot delete a flow with no versioned snapshots
• links to: GitHub Pull Request #146