[NIFI-9797] AccessToken isExpired broken

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.16.0
• Fix Version/s: 1.16.0
• Component/s: Core Framework
• Assignee: David Handermann
• Reporter: Lawrence
• Created: 14/Mar/22 21:05
• Updated: 17/Mar/22 14:20
• Resolved: 14/Mar/22 22:34

Description

While using a build of the current snapshot (1.16.0) so i could use the new StandardOAuth2AccessTokenProvider I ran into an issue with how the AccessToken got changed to calculate if the token is expired.  This is going to break potentially a lot of folks using that AccessToken.  It's subtracting 5000 seconds from the expiresIn property.  I think it was assumed that expires_in would be in millis also, but it is not, per OAuth standards:
https://datatracker.ietf.org/doc/html/rfc6749#section-4.2.2
Here is a link to the PR that got merged where I added a comment ( to little to late ).
https://github.com/apache/nifi/pull/5319#pullrequestreview-909366668

Issue Links

• relates to: NIFI-9801 AccessToken isExpired fixed incorrectly
• relates to: NIFI-9807 Add Refresh Window Property to OAuth2 Token Provider
• links to: GitHub Pull Request #5867