[NIFI-8537] Components become invalid if referencing a disabled controller service, even if referencing property is not in scope due to dependencies

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Component/s: Core Framework
• Assignee: Mark Payne
• Reporter: Mark Payne
• Created: 12/May/21 19:06
• Updated: 13/May/21 15:38
• Resolved: 13/May/21 15:38

Description

If a processor/controller service property (A) has a dependency on another property (B), we do not perform validation of property A (i.e., the property descriptor's validator is ignored). However, if Property A references a Controller Service, and that Controller Service is either disabled or invalid, we currently consider the referencing component invalid. This should not be the case.

To replicate:

• Create an AvroSchemaRegistry Controller Service. Leave the Controller Service disabled.
• Create a JsonTreeReader controller service.
• Configure the JsonTreeReader Controller Service.
• Set "Schema Access Strategy" to "Use 'Schema Name' Property"
• Set "Schema Registry" to the AvroSchemaRegistry created in the first step.
• Change "Schema Access Strategy" to "Infer Schema"
• Click Apply to apply the changes.

The JsonTreeReader service will be invalid due to the fact that AvroSchemaRegistry is disabled. Not only should the Schema Registry property not be considered in validation, it becomes very confusing now because the validation error states: "'Schema Registry' validated against XYZ is invalid because Controller Service with ID XYZ is invalid." But when configuring JsonTreeReader, we don't even see the "Schema Registry" property.

The reference should not be validated unless its property's dependencies have been satisfied.

Issue Links

• links to: GitHub Pull Request #5071