[NIFI-8492] IPLookupService not working since 1.8.0?

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.16.0
• Component/s: Extensions
• Labels: IPLookupService
• Assignee: Matt Burgess
• Reporter: Benjamin Charron
• Created: 27/Apr/21 22:05
• Updated: 17/Feb/22 18:06
• Resolved: 17/Feb/22 18:06

Description

IPLookupService, like its cousin GeoEnrichIP, uses maxmind/DatabaseReader.java

However, because they are in different NARs, they each have their own "DatabaseReader.java
". GeoEnrichIP's version had a bug fixed back in 1.9.0 (https://issues.apache.org/jira/browse/NIFI-5814), but IPLookupService did not.

As far as I can tell, IPLookupService has also been broken since 1.8.0. We get the following error with the IPLookupService in 1.11.4:

Caused by: java.lang.UnsupportedOperationException: null
        at java.util.Collections$UnmodifiableMap.put(Collections.java:1457)
        at com.fasterxml.jackson.databind.node.ObjectNode.set(ObjectNode.java:370)
        at org.apache.nifi.lookup.maxmind.DatabaseReader.get(DatabaseReader.java:158)
        at org.apache.nifi.lookup.maxmind.DatabaseReader.city(DatabaseReader.java:194)
        at org.apache.nifi.lookup.maxmind.IPLookupService.doLookup(IPLookupService.java:262)

Should the fixes in GeoEnrichIP's DatabaseReader also be copied to IPLookupService's DatabaseReader? Or is there a way for them to use the same one without copying the file?

Issue Links

• links to: GitHub Pull Request #5777