[NIFI-7314] HandleHttpRequest should stop Jetty in OnUnscheduled instead of OnStopped

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: Extensions
• Assignee: Tamas Palfy
• Reporter: Peter Turcsanyi
• Created: 03/Apr/20 16:03
• Updated: 07/Apr/20 18:17
• Resolved: 07/Apr/20 18:17

Description

Jetty server is being stopped in OnStopped currently.
OnStopped runs only after the ongoing onTigger() calls have finished, but if the onTrigger() thread hangs up for some reason, OnStopped will never be called and Jetty won't be stopped (which would probably cease the hang-up in onTrigger).

To avoid this possible hang-up: move the stopping logic from OnStopped to OnUnschedule which runs just after the user clicks Stop.

Graceful shutdown could also be implemented: at the beginning of OnUnschedule wait for ongoing request to be finished for a while (with some timeout to avoid hang-up here). Also reject new requests in this period with HTTP 503 + "Server shutting down" response.

Issue Links

• links to: GitHub Pull Request #4191