[NIFI-6795] Fix bug in CouchbaseMapCacheClient.java which prevents new Couchbase Object from being created

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.11.0
• Component/s: Extensions
• Labels: Couchbase
• Assignee: Unassigned
• Reporter: John E Fortin
• Created: 21/Oct/19 22:39
• Updated: 06/Dec/19 06:08
• Resolved: 06/Dec/19 06:06

Description

The function below has a bug: 

@Override
 public <K, V> boolean replace(AtomicCacheEntry<K, V, Long> entry, Serializer<K> keySerializer, Serializer<V> valueSerializer) throws IOException {
 final Long revision = entry.getRevision().orElse(0L);
 final String docId = toDocumentId(entry.getKey(), keySerializer);
 final Document doc = toDocument(docId, entry.getValue(), valueSerializer, revision);
 try {
 if (revision < 0) {
 // If the document does not exist yet, try to create one.
 try {
 bucket.insert(doc);
 return true;
 } catch (DocumentAlreadyExistsException e) {
 return false;
 }

final Long revision = entry.getRevision().orElse(0L);

should be

final Long revision = entry.getRevision().orElse(-1L);

otherwise a new document never gets created in the check

if (revision < 0) {
 // If the document does not exist yet, try to create one.
 try {
 bucket.insert(doc);
 return true;
 } catch (DocumentAlreadyExistsException e) {
 return false;
 }

I have tested the code change locally and it works properly...

 

--John