[NIFI-674] FileSystemRepository should not create new threads in its constructor

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.1.0
• Fix Version/s: 0.2.0
• Component/s: Core Framework
• Assignee: Dan Bress
• Reporter: Mark Payne
• Created: 09/Jun/15 21:29
• Updated: 26/Jun/15 23:32
• Resolved: 26/Jun/15 23:32

Description

FileSystemRepository creates two different ExecutorServices in its constructor. This is problematic because we iterate over the ServiceLoader, which creates an instance of FileSystemRepository and then throws it away.

Instead, these executors should be created in the initialize method.

It should also be documented in the ContentRepository interface that any time that initialize() is called, it is expected that the shutdown() method will also be called, as this is where we can cleanup the things that we did during initialization. This was the intended lifecycle but never was clearly documented.

Issue Links

• Is contained by: NIFI-632 Documentation Generation: Nar ClassLoader