[NIFI-6420] Controller Service references not properly tracked if multiple references from same component

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Component/s: Core Framework
• Labels: cleanup codesmell refactor
• Assignee: Alessandro D'Armiento
• Reporter: Mark Payne
• Created: 03/Jul/19 18:49
• Updated: 10/Aug/19 09:06
• Resolved: 09/Aug/19 19:23

Description

The StandardControllerServiceNode keeps track of any references to it via `addReference` and `removeReference` methods. However, if a Processor (or another Controller Service) has two different properties that reference the service, then the references can become incorrect.

This is due to the fact that when Properties are set for a component, we determine that Property A previously referenced Service 123 but no longer does and call `removeReference` on Service 123. However, if Property B also is referencing Service 123, we have a condition where the Processor is referencing Service 123, but Service 123 does not know about it, because of the call to `removeReference`.

We should either be storing references as a `List` in `StandardControllerServiceNode` or else should determine whether or not all references have been removed before calling `removeReference`. I suspect that the latter is less error-prone, given that calls to `addReference` currently are idempotent and changing the data structure to a `List` would mean that the method is no longer idempotent.

Issue Links

• is related to: NIFI-6371 Validation still occurs for deleted 'Controller Level' Controller Services
• links to: GitHub Pull Request #3600