[NIFI-5795] RedisDistributedMapCacheClientService put missing option

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.9.0
• Component/s: Extensions
• Assignee: Unassigned
• Reporter: Alex
• Created: 06/Nov/18 18:45
• Updated: 17/Feb/19 01:52
• Resolved: 03/Dec/18 09:40

Description

When you select on PutDistributedMapCache CACHE_UPDATE_STRATEGY = CACHE_UPDATE_REPLACE we execute "cache.put(cacheKey, cacheValue, keySerializer, valueSerializer);" LINK

If you use redis as backend service this jumps to: RedisDistributedMapCacheClientService.java -> redisConnection.set(kv.getKey(), kv.getValue(), Expiration.seconds(ttl), null); LINK

Calling to spring-data/redis/ library, but we have a bug putting null as Option parameter, causing an error "option cannot be null", because according to library: "option - must not be null." Library Link

If we want to update strategy we should use: RedisStringCommands.SetOption.upsert()

 

 

 

 

Issue Links

• is duplicated by: NIFI-6048 RedisDistributedMapCache non null error
• is related to: NIFI-5830 RedisConnectionPoolService does not work with Standalone Redis using non-localhost deployment
• links to: GitHub Pull Request #3135