GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/3085
NIFI-5711 NLKBufferedReader appears extend and copy portions of the J…
…DK BufferedReader
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-
-
- For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
-
-
- For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
-
-
- For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
-
-
- Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-5711
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3085
commit d0d9f0172839e62cf624fe1801f8f532d42a783d
Author: patricker <patricker@...>
Date: 2018-10-16T21:56:55Z
NIFI-5711 NLKBufferedReader appears extend and copy portions of the JDK BufferedReader
our source: https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/NLKBufferedReader.java
jdk source: http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/java/io/BufferedReader.java
This is clearly copying numerous lines of code.