Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-561

FileBasedClusterNodeFirewallTest should rely on JUnit / Maven norms for test files.

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.0.1
    • 0.1.0
    • Core Framework
    • None

    Description

      Right now FileBasedClusterNodeFirewallTest sets up its own test directory and reads test files directly out of hte source tree.

      These are both undesirable

      • setting up a temp directory in java.io.tmp manually makes more work when we could use a junit tempdirectory (it also makes it more likely that we'll mess up parallel builds)
      • reading out of the source tree prevents adding in maven rules that process the test resources before the test (as opposed to reading them out of target/classes, where teh test resource handler will put the finished products).

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            busbey Sean Busbey
            busbey Sean Busbey
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment