GitHub user snagafritz opened a pull request:
https://github.com/apache/nifi/pull/2913
NIFI-5083: enabled EL support for processor configuration of Kafka consumer group id
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-
-
- For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
-
-
- For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
```
I started to write unit tests for these changes then realized that the tests were really verifying the evaluation of the EL expressions, and I assume far better unit tests for this already exist. I will attach a video of me verifying expected behavior of a build of this branch to the JIRA ticket.
```
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
-
-
- For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
-
-
- Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Snagajob/nifi NIFI-5083
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2913.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2913
commit 9d0a1ecd1d83ee2c6e54e3018db41280876a9629
Author: Corey Fritz <corey.fritz@...>
Date: 2018-07-07T05:28:50Z
NIFI-5083: enabled EL support for processor configuration of Kafka consumer `group.id` property
rbruno does this mean you're using the FlowRegistry to ensure both clusters have a consistent flow and thus are ending up with the same group id being used?
Adding support for EL to let variables be used is a very doable option and a good idea. Just wanted to understand how you're keeping the flows so in sync between clusters that this would be matching at this time.
Thanks