Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-228

assembly: use non-deprecated maven goals and build assembly by default

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.0.1
    • Component/s: Tools and Build
    • Labels:
      None

      Description

      We presently require the assembly:assembly goal. This has been deprecated for quite some time. We should support assembly:single but that doesn't work now with our current structure. Also, assembly plugin handles unpacking so we can use a more standard approach. Also the assembly build should occur as a normal part of the lifecycle. A user shouldn't have to execute that in addition to the normal build.RPM plugin doens't have the flexibility of the assembly plugin though so for now it will need to still use the generated-source trick.

      1. NIFI-228.patch
        15 kB
        Joseph Witt

        Activity

        Hide
        joewitt Joseph Witt added a comment -

        have tested the above patch on develop.

        Tested full clean build.

        Tested clean install
        Teste install
        Tested assembly:assembly
        Tested assembly:single
        Tested -Prpm install

        Seems much better now.

        Show
        joewitt Joseph Witt added a comment - have tested the above patch on develop. Tested full clean build. Tested clean install Teste install Tested assembly:assembly Tested assembly:single Tested -Prpm install Seems much better now.
        Hide
        mcgilman Matt Gilman added a comment -

        +1 to merge to develop... Built fine on...

        Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; 2014-08-11T16:58:10-04:00)
        Maven home: /usr/local/Cellar/maven/3.2.3/libexec
        Java version: 1.7.0_71, vendor: Oracle Corporation
        Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_71.jdk/Contents/Home/jre
        Default locale: en_US, platform encoding: UTF-8
        OS name: "mac os x", version: "10.10.1", arch: "x86_64", family: "mac"

        Show
        mcgilman Matt Gilman added a comment - +1 to merge to develop... Built fine on... Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; 2014-08-11T16:58:10-04:00) Maven home: /usr/local/Cellar/maven/3.2.3/libexec Java version: 1.7.0_71, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_71.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.10.1", arch: "x86_64", family: "mac"
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 33ad7934eaaf257190c3e96f6ecf46b378808912 in incubator-nifi's branch refs/heads/develop from Joseph Witt
        [ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=33ad793 ]

        NIFI-228 fixed build to always create assembly non-attached and to use curren maven approaches

        Show
        jira-bot ASF subversion and git services added a comment - Commit 33ad7934eaaf257190c3e96f6ecf46b378808912 in incubator-nifi's branch refs/heads/develop from Joseph Witt [ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=33ad793 ] NIFI-228 fixed build to always create assembly non-attached and to use curren maven approaches
        Hide
        joewitt Joseph Witt added a comment -

        and updated website to reflect simpler build process

        Show
        joewitt Joseph Witt added a comment - and updated website to reflect simpler build process

          People

          • Assignee:
            joewitt Joseph Witt
            Reporter:
            joewitt Joseph Witt
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development