Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-1647

Spring context processor usability issue

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.6.0
    • None
    • None

    Description

      Here are a couple observations/things to improve on the Spring processors included in 0.6.0.

      1) The validators for the classpath and context properties should not be validating eachother. When compound validation is needed that is the job of customValidate. They should each have simple validators like checking for a directory in the case of the path and checking not empty in the case of the context. Then, customValidate should run the logic currently held in SpringContextValidator. Doing this will eliminate the two warnings that come out now whenever one of them isn't right.

      2) It seems really unclear how one can add new spring context xmls. Is it at startup only? When adding the processor only? I've tried putting a new one in the path directory and putting one in the conf directory but still it doesn't seem to find it. It appears some code cleanup/clarity is needed but at very least we should document what the user should expect/do to load new context configs.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ozhurakousky Oleg Zhurakousky
            joewitt Joe Witt
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment