Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-1456

TestExecuteStreamCommand.testExecuteIngestAndUpdate() using excessively large input

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.5.0
    • Extensions
    • None

    Description

      Big thanks to https://github.com/PuspenduBanerjee for identifying the issue.

      This test is creating a 100MB file then scanning it in a java executable that is fired up with whatever the environ default heap sizing/etc.. is. In some environments, notably Travis-CI, this is creating build stability problems.

      There is no apparent reason to match against such a large file.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user joewitt opened a pull request:

            https://github.com/apache/nifi/pull/198

            NIFI-1456 reduced tests to 10MB instead of 100MB datasets and resolve…

            …d IO issues which impact test stability

            Signed-off-by: joewitt <joewitt@apache.org>

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/joewitt/incubator-nifi master

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/nifi/pull/198.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #198


            commit 072486942140121571f5340220c22c60ebf378b5
            Author: joewitt <joewitt@apache.org>
            Date: 2016-02-01T02:00:38Z

            NIFI-1456 reduced tests to 10MB instead of 100MB datasets and resolved IO issues which impact test stability

            Signed-off-by: joewitt <joewitt@apache.org>


            githubbot ASF GitHub Bot added a comment - GitHub user joewitt opened a pull request: https://github.com/apache/nifi/pull/198 NIFI-1456 reduced tests to 10MB instead of 100MB datasets and resolve… …d IO issues which impact test stability Signed-off-by: joewitt <joewitt@apache.org> You can merge this pull request into a Git repository by running: $ git pull https://github.com/joewitt/incubator-nifi master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/198.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #198 commit 072486942140121571f5340220c22c60ebf378b5 Author: joewitt <joewitt@apache.org> Date: 2016-02-01T02:00:38Z NIFI-1456 reduced tests to 10MB instead of 100MB datasets and resolved IO issues which impact test stability Signed-off-by: joewitt <joewitt@apache.org>
            joewitt Joe Witt added a comment -

            the attached patch file can be ignored. I then did a proper PR to verify the Travis-CI world is now happy. Which it is: https://travis-ci.org/apache/nifi/builds/106125685

            joewitt Joe Witt added a comment - the attached patch file can be ignored. I then did a proper PR to verify the Travis-CI world is now happy. Which it is: https://travis-ci.org/apache/nifi/builds/106125685
            bbende Bryan Bende added a comment -

            +1 Looks good, build passed in travis for the PR.

            bbende Bryan Bende added a comment - +1 Looks good, build passed in travis for the PR.
            tkurc Tony Kurc added a comment -

            I have reviewed. Please merge in, joewitt

            tkurc Tony Kurc added a comment - I have reviewed. Please merge in, joewitt

            Commit 1bf7a585b2c622069ba6e9cd84b041997d367e01 in nifi's branch refs/heads/master from joewitt
            [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1bf7a58 ]

            NIFI-1456 This closes #198. reduced tests to 10MB instead of 100MB datasets and resolved IO issues which impact test stability

            jira-bot ASF subversion and git services added a comment - Commit 1bf7a585b2c622069ba6e9cd84b041997d367e01 in nifi's branch refs/heads/master from joewitt [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1bf7a58 ] NIFI-1456 This closes #198. reduced tests to 10MB instead of 100MB datasets and resolved IO issues which impact test stability
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/nifi/pull/198

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/198
            joewitt Joe Witt added a comment -

            thank you both. Credit goes to puspendu.banerjee@gmail.com for finding the real root issue.

            joewitt Joe Witt added a comment - thank you both. Credit goes to puspendu.banerjee@gmail.com for finding the real root issue.

            People

              joewitt Joe Witt
              joewitt Joe Witt
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: