[NIFI-13755] Controller Services sometimes not restarted when NiFi is restarted

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.27.0, 2.0.0-M4
• Fix Version/s: 1.28.0, 2.0.0
• Component/s: Core Framework
• Assignee: Jim Steinebrey
• Reporter: Jim Steinebrey
• Created: 17/Sep/24 14:47
• Updated: 21/Oct/24 17:34
• Resolved: 18/Oct/24 18:06

Description

Before Nifi was stopped, there were around 1000 controller services (cs) enabled and 500 disabled. After NiFi restarted, none of the controller services were enabled. This is very inconvenient because now someone has to manually restart just the 1000 that should be enabled. The normal NiFi restart behavior is to enable the 1000 cs and leave the 500 disabled to restore them to their state before the restart.

I found the cause in StandardControllerServiceProvider.enableControllerServices()
If a single enabled cs depends on another cs which is disabled, then NONE of the 1000 cs are enabled.

My change is to only SKIP the enabling of any cs which is dependent on any disabled cs ancestor (cs can be linked multiple levels deep) and proceed to enable any cs which is not dependent on a disabled cs ancestor.

Issue Links

• links to: GitHub Pull Request #9273