[NIFI-12885] Update Record Date and Time get Methods

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-M2
• Fix Version/s: 2.0.0-M3
• Assignee: crissaegrim
• Reporter: crissaegrim
• Created: 11/Mar/24 20:10
• Updated: 25/Apr/24 04:25
• Resolved: 25/Apr/24 04:25

Description

I think I found a breaking bug from this commit https://github.com/apache/nifi/commit/250fe90b348fac515ea597c1985ca432ac7c3ac3#diff-ce496d3f0fc5a7e8a3c0431972f7069b4cf1af2e94f3a199f595ef195eb5ebfa

The below passes in 1.20.0 but fails in 2.0

    @Test
    void testBasic() throws Exception {
        // setup
        final String schemaText = "{" +
                "\"type\" : \"record\"," +
                "\"name\" : \"TestRecord\"," +
                "\"namespace\" : \"org.apache.nifi\"," +
                "\"fields\" : [ {" +
                "\"name\" : \"my_datestamp_field\"," +
                "\"type\" : {" +
                "\"type\" : \"long\"," +
                "\"logicalType\" : \"timestamp-millis\"" +
                "}" +
                "} ]" +
              "}";
        final RecordSchema schemaParsed = AvroTypeUtil.createSchema(new Schema.Parser().parse(schemaText));

        final HashMap<String, Object> item = new HashMap<>();
        item.put("my_datestamp_field", "2022-01-01 10:00:00.000");

        // act
        final MapRecord record = new MapRecord(schemaParsed, item);
        final Date myDateStampField = record.getAsDate("my_datestamp_field", "yyyy-MM-dd HH:mm:ss.SSS");

        // assert
	// fails in 2.0; actual in 2.0.0-M2 is `1640995200000`
        assertEquals(1641031200000L, myDateStampField.getTime());
    }

Issue Links

• is related to: NIFI-9458 Refactor NiFi to use Java 8 Time classes
• links to: GitHub Pull Request #8502