[NIFI-12696] Fix authorization issues when requesting FlowAnalysisResults

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-M3
• Assignee: Tamas Palfy
• Reporter: Tamas Palfy
• Created: 30/Jan/24 16:24
• Updated: 09/Feb/24 14:28
• Resolved: 09/Feb/24 14:28

Description

When requesting FlowAnalysisResults the authorization logic performed has a couple of issues:

1. Doesn't handle exceptions thrown when the a component producing a result is tested to be a Port. The logic goes through possible component types and when reaches Ports it throws an exception.
2. As the logic goest through possible components, the mismatching ones throw ResourceNotFoundExceptions. These are captured but this is a bad practice in general. Throwing and capturing exceptions in non-exceptional cases is bad from both design and performance perspective.
3. The number of possible components checked is too limited. If a component is unrecognized, the corresponding violation will have a PermissionDTO attached with canRead and canWrite set to false, essentially rendering the result unavailable and thus leading to a false negative.

Issue Links

• links to: GitHub Pull Request #8318