[NIFI-10059] Controller service could incorrectly be removed from cache

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.16.2
• Fix Version/s: 1.17.0, 1.16.3
• Assignee: Bryan Bende
• Reporter: Bryan Bende
• Created: 26/May/22 18:04
• Updated: 13/Jun/22 15:36
• Resolved: 26/May/22 21:13

Description

The remove method in StandardControllerServiceProvider has two calls to remove the service from the cache, and one of them happens before the service is actually removed:

https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java#L542

If the remove fails after this, the service is already removed from the cache. Later if someone asks for this service by id from the provider, it will return null because it is not in the cache anymore.

A normal REST call shouldn't reach this case because it would call verifyDelete before getting here, and the delete shouldn't fail if it passed verify, but other backend code could potentially take a different path.

Issue Links

• links to: GitHub Pull Request #6082