[NETBEANSINFRA-187] nbmBuildDir conflict between targets nbm and cluster because of wrong usage

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: NBM Maven Plugin 4.5
• Fix Version/s: NBM Maven Plugin 4.6
• Component/s: MU - Apache NetBeans NBM maven plugin
• Labels: pull-request-available
• Assignee: Jean-Marc Borer
• Reporter: Jean-Marc Borer
• Created: 26/Apr/20 09:51
• Updated: 28/Apr/20 12:02
• Resolved: 28/Apr/20 12:02

Description

The nbmBuildIDir parameter is used both in nbm and cluster targets. However the meaning in those two contexts are different:

1) nbm: output directory where the NBMs will be created from the Jars and other meta data

2) cluster: directory where to copy the NBMS to from the hardcoded $(based}/nbm/netbeans

This is usually not a problem as long a you work with netbeans, but it becomes if you want to use the targets with other projects such as VisualVM.

By looking at the code, this seems more a like bug. What the cluster target should actually do is look for the NBMs, not in the hard coded location, but in the one provided by nbmBuildDir and use clusterBuildDir instead to define the target cluster location build. This very same parameter will be reused by the run-ide target.   

Issue Links

• links to: GitHub Pull Request #9