[NETBEANS-687] Code Refactoring Must respect code style, formatting, spacing and layout

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 9.0
• Component/s: editor - Refactoring, java - Refactoring
• Labels: Regression code-generation formatting

Environment

Product Version: Apache NetBeans IDE Dev (Build incubator-netbeans-release-205-on-20180202)
Java: 10; Java HotSpot(TM) 64-Bit Server VM 10+46
Runtime: Java(TM) SE Runtime Environment 10+46
System: Windows 10 version 10.0 running on amd64; Cp1252; en_AU (nb)
User directory: Z:\tmp\.other\user\netbeans\v09.00-beta\FourAbs
Cache directory: Z:\tmp\.other\cache\netbeans\FourAbs-09

• Assignee: Unassigned
• Reporter: aplatypus
• Created: 18/Apr/18 04:10
• Updated: 04/May/18 02:00

Description

expected

• I expect automatic code edits to respect code layout as much as possible
• For example the code layout below should NOT change, following...
• Rename of 'jComboBoxCorridor' --> 'jComboBoxSectionCorridor'

        //  Example 1
      helper.enable(
          jComboBoxNoteType,
          jComboBoxSectionCorridor
      );
  
          //  Example 2
  
      helper.enable
      (
          jComboBoxNoteType,
          jComboBoxSectionCorridor
      );
  
      // Example 3
  
      helper.setEnabled(
          jRadioButtonSection.isSelected() && enabled,
              jComboBoxSectionCorridor,
              jComboBoxNirCode
      );
  

actual

• This is highly undesirable
• The first two code examples are change to the following:

      helper.enable(jComboBoxNoteType,
          jComboBoxSectionCorridor
      );
  

• Example 3 results in a even less desirable change:

      helper.enable
      (jRadioButtonSection.isSelected() && enabled,
              jComboBoxSectionCorridor,
              jComboBoxNirCode
  

  • In this case the indenting was showing that the boolean result is applied to all the indented fields.
  • That information has been lost and was overlooked during debugging
• These changes are definitely potential source for application code bugs