[NETBEANS-565] Missing Css3.g file from donation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.0
• Fix Version/s: 11.0
• Component/s: web - CSS Editor
• Labels: 11.0-vc1 pull-request-available
• Assignee: Matthias Bläsing
• Reporter: Matthias Bläsing
• Created: 02/Apr/18 10:47
• Updated: 03/Nov/19 20:09
• Resolved: 19/Nov/18 20:43

Description

While investigating a potential CSS parser error I saw while working with NB9
and noticed, that one of the most important files is missing:

css.lib/src/org/netbeans/modules/css/lib/Css3.g

that file holds an antlr3 grammer for CSS 3. That file was not donated
and I think the reason is, that the header contains a different
copyright:

 // Author      : Jim Idle, Temporal Wave LLC.
 // Contact     : [e-mail]
 // Website     : http://www.temporal-wave.com
 // License     : ANTLR Free BSD License

My investigation showed, that the file is based on:

https://github.com/antlr/grammars-v3/blob/master/css21/css21.g
or
https://github.com/antlr/grammars-v3/raw/master/css21/css21.g

the headers and big chunks of the first checkin of Css3.g match.

I see that oracle might feel uncomfortable/prohibited donating the
whole file, but what could be donated is a diff between the original
file from the antlr repository and the current state in netbeans.

In technical term I suggest, that the patch against the base file is
donated:

# Get basefile
wget https://github.com/antlr/grammars-v3/raw/master/css21/css21.g
# Get netbeans state
wget http://hg.netbeans.org/releases/raw-file/tip/css.lib/src/org/netbeans/modules/css/lib/Css3.g
# Create patch
diff -u css21.g Css3.g > nb_css_parser.patch

That diff than only contains changes done by netbeans committers and this is
either covered by the normal Oracle copyright (employees working on
netbeans) or the OCLA.
Maybe it helps, that there are only three authors listed in the history (taken from the releases repository):

• Marek Fukala <[e-mail]>
• Milutin Kristofic <[e-mail]>
• Ondrej Brejla <[e-mail]>

As requested by mail I created this issue to track the donation. I attached the diff/patch described above to this issue. I did not touch the file after creating the diff, as the license headers can be adjusted if/when oracle agrees to donate the contents (I'm willing to do the integration).

Issue Links

• is depended upon by: NETBEANS-747 CSS Editor does not recognize variable syntax
• links to: GitHub Pull Request #1020