[NETBEANS-5070] Partitial fix for NETBEANS-819 breaks terminal

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: Next
• Fix Version/s: 12.3
• Component/s: cnd - Terminalemulator
• Labels: pull-request-available
• Assignee: Matthias Bläsing
• Reporter: Matthias Bläsing
• Created: 26/Nov/20 20:26
• Updated: 05/Feb/21 20:53
• Resolved: 02/Jan/21 17:26

Description

The fix for shifted cursor in terminal windows commited by:

https://github.com/apache/netbeans/pull/2509

Breaks text selection (video provided by lkishalmi ):

I also saw that behavior on windows and on linux I observed flaky behavior of the terminal and this is matched by exceptions:

SEVERE [global]
java.lang.ArrayIndexOutOfBoundsException: Index 134 out of bounds for length 134
at java.desktop/sun.font.FontDesignMetrics.charsWidth(FontDesignMetrics.java:506)
at org.netbeans.lib.terminalemulator.Line.stringWidth(Line.java:159)
at org.netbeans.lib.terminalemulator.Sel.paint(Sel.java:407)
at org.netbeans.lib.terminalemulator.Sel.access$000(Sel.java:71)
at org.netbeans.lib.terminalemulator.Sel$2.visit(Sel.java:436)
at org.netbeans.lib.terminalemulator.Buffer.visitLines(Buffer.java:205)
at org.netbeans.lib.terminalemulator.Term.visitLines(Term.java:912)
at org.netbeans.lib.terminalemulator.Sel.paint(Sel.java:434)
at org.netbeans.lib.terminalemulator.Term.do_paint(Term.java:3175)
at org.netbeans.lib.terminalemulator.Screen.paint(Screen.java:168)
at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)

So we either need a quick fix for this or we need to rollback the referenced commit.

Issue Links

• links to: GitHub Pull Request #2597