Uploaded image for project: 'NetBeans'
  1. NetBeans
  2. NETBEANS-5070

Partitial fix for NETBEANS-819 breaks terminal

    XMLWordPrintableJSON

    Details

      Description

      The fix for shifted cursor in terminal windows commited by:

      https://github.com/apache/netbeans/pull/2509

      Breaks text selection (video provided by Laszlo Kishalmi ):

      I also saw that behavior on windows and on linux I observed flaky behavior of the terminal and this is matched by exceptions:

      SEVERE [global]
      java.lang.ArrayIndexOutOfBoundsException: Index 134 out of bounds for length 134
      at java.desktop/sun.font.FontDesignMetrics.charsWidth(FontDesignMetrics.java:506)
      at org.netbeans.lib.terminalemulator.Line.stringWidth(Line.java:159)
      at org.netbeans.lib.terminalemulator.Sel.paint(Sel.java:407)
      at org.netbeans.lib.terminalemulator.Sel.access$000(Sel.java:71)
      at org.netbeans.lib.terminalemulator.Sel$2.visit(Sel.java:436)
      at org.netbeans.lib.terminalemulator.Buffer.visitLines(Buffer.java:205)
      at org.netbeans.lib.terminalemulator.Term.visitLines(Term.java:912)
      at org.netbeans.lib.terminalemulator.Sel.paint(Sel.java:434)
      at org.netbeans.lib.terminalemulator.Term.do_paint(Term.java:3175)
      at org.netbeans.lib.terminalemulator.Screen.paint(Screen.java:168)
      at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
      at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
      at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
      at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)

      So we either need a quick fix for this or we need to rollback the referenced commit.

        Attachments

        1. after2_scale2.png
          162 kB
          Matthias Bläsing
        2. after_scale2.png
          27 kB
          Matthias Bläsing
        3. before2_scale2.png
          186 kB
          Matthias Bläsing
        4. before2_scale1.png
          94 kB
          Matthias Bläsing
        5. after2_scale1.png
          56 kB
          Matthias Bläsing
        6. before_scale2.png
          26 kB
          Matthias Bläsing
        7. after_scale1.png
          14 kB
          Matthias Bläsing
        8. before_scale1.png
          12 kB
          Matthias Bläsing
        9. Bildschirmfoto_2020-12-30_17-07-10.png
          40 kB
          Matthias Bläsing
        10. 99895991-55dd6080-2c41-11eb-9019-c7c96214a802.gif
          73 kB
          Matthias Bläsing

          Issue Links

            Activity

              People

              • Assignee:
                matthiasblaesing Matthias Bläsing
                Reporter:
                matthiasblaesing Matthias Bläsing
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 10m
                  1h 10m