[NETBEANS-4832] fxml code completion fails with modular java

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 12.2
• Component/s: javafx - Editor
• Labels: modularization pull-request-available pull-requests-available

Environment

NB-12.1, jdk-14, no nb-javac, Win7, no userdir/cachedir,
startup do not import settings

• Assignee: Ernie Rael
• Reporter: Ernie Rael
• Created: 22/Sep/20 01:12
• Updated: 05/Feb/21 21:04
• Resolved: 02/Jan/21 22:06

Description

To reproduce (create/open fxml file)

1. NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
2. Open primary.fxml, in "other sources" "source/main/resources" <package>
3. put cursor within xml, for example after "<children>"
4. Enter Ctrl-Space to bring up code completion

Observe:

• Typically have to go through a couple web certification dialogs
• Typically repeat Ctrl-Space and there's a "downloading..." that never finishes

Note: Works OK when running on and using jdk1.8 with nb-javac.

Fails with JDK assertion: Assert.checkNonNull(allModules)

(full message log attached)

java.lang.AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at jdk.compiler/com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62) at jdk.compiler/com.sun.tools.javac.comp.Modules.allModules(Modules.java:1205) at jdk.compiler/com.sun.tools.javac.model.JavacElements.getAllModuleElements(JavacElements.java:126) at org.netbeans.modules.java.source.ElementUtils.getTypeElementByBinaryName(ElementUtils.java:49) at org.netbeans.api.java.source.ElementHandle.getTypeElementByBinaryName(ElementHandle.java:666) at org.netbeans.api.java.source.ElementHandle.resolveImpl(ElementHandle.java:163) at org.netbeans.api.java.source.ElementHandle.resolve(ElementHandle.java:132) at org.netbeans.modules.javafx2.editor.completion.impl.InstanceCompleter.<init>(InstanceCompleter.java:54)

Issue Links

• links to: GitHub Pull Request #2399